narendly commented on a change in pull request #809: Add system property options to config write size limit for ZNRecord Serializer URL: https://github.com/apache/helix/pull/809#discussion_r386009510
########## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/ZNRecordUtil.java ########## @@ -0,0 +1,65 @@ +package org.apache.helix.zookeeper.util; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import org.apache.helix.zookeeper.constant.ZkSystemPropertyKeys; +import org.apache.helix.zookeeper.datamodel.ZNRecord; + + +/** + * This utility class contains various methods for manipulating ZNRecord. + */ +public class ZNRecordUtil { + + /** + * Checks whether or not a serialized ZNRecord bytes should be compressed before being written to + * Zookeeper. + * + * @param record raw ZNRecord before being serialized + * @param serializedLength length of the serialized bytes array + * @return + */ + public static boolean shouldCompress(ZNRecord record, int serializedLength) { + if (record.getBooleanField(ZNRecord.ENABLE_COMPRESSION_BOOLEAN_FIELD, false)) { + return true; + } + + boolean autoCompressEnabled = Boolean.parseBoolean(System + .getProperty(ZkSystemPropertyKeys.ZK_SERIALIZER_ZNRECORD_AUTO_COMPRESS_ENABLED, + ZNRecord.ZK_SERIALIZER_ZNRECORD_AUTO_COMPRESS_DEFAULT)); Review comment: Nit: can't we just put `true` here instead of creating ZK_SERIALIZER_ZNRECORD_AUTO_COMPRESS_DEFAULT? It seems like it's a bit of an overkill. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
