pkuwm commented on a change in pull request #838: Make ConfigAccessor and
ZkUtil realm-aware
URL: https://github.com/apache/helix/pull/838#discussion_r386711233
##########
File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java
##########
@@ -66,6 +67,10 @@ public static boolean isClusterSetup(String clusterName,
String zkAddress) {
}
public static boolean isClusterSetup(String clusterName, HelixZkClient
zkClient) {
Review comment:
If we have `public static boolean isClusterSetup(String clusterName,
RealmAwareZkClient zkClient)`, it seems keeping this old API `public static
boolean isClusterSetup(String clusterName, HelixZkClient zkClient)` is
redundant, because `HelixZkClient` is a subclass of `RealmAwareZkClient`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
