jiajunwang commented on a change in pull request #845: Async write operation
should not throw Exception for serializing error
URL: https://github.com/apache/helix/pull/845#discussion_r386747374
##########
File path:
helix-core/src/test/java/org/apache/helix/manager/zk/TestRawZkClient.java
##########
@@ -745,4 +749,65 @@ public void testWaitForEstablishedSession() {
// Recover zk server for later tests.
_zkServer.start();
}
+
+ @Test
+ public void testAsyncWriteOperations() {
+ ZkClient zkClient = new ZkClient(ZK_ADDR);
+ String originSizeLimit =
+
System.getProperty(ZkSystemPropertyKeys.ZK_SERIALIZER_ZNRECORD_WRITE_SIZE_LIMIT_BYTES);
+
System.setProperty(ZkSystemPropertyKeys.ZK_SERIALIZER_ZNRECORD_WRITE_SIZE_LIMIT_BYTES,
"2000");
+ try {
+ zkClient.setZkSerializer(new ZNRecordSerializer());
+
+ ZNRecord oversizeZNRecord = new ZNRecord("Oversize");
+ StringBuilder sb = new StringBuilder(1204);
+ Random ran = new Random();
+ for (int i = 0; i < 1024; i++) {
+ sb.append(ran.nextInt(26) + 'a');
+ }
+ String buf = sb.toString();
+ for (int i = 0; i < 1024; i++) {
+ oversizeZNRecord.setSimpleField(Integer.toString(i), buf);
+ }
+
+ // ensure /tmp exists for the test
+ if (!zkClient.exists("/tmp")) {
+ zkClient.create("/tmp", null, CreateMode.PERSISTENT);
+ }
+
+
org.apache.helix.zookeeper.zkclient.callback.ZkAsyncCallbacks.CreateCallbackHandler
+ createCallback = new
org.apache.helix.zookeeper.zkclient.callback.ZkAsyncCallbacks.CreateCallbackHandler();
+ zkClient.asyncCreate("/tmp/async", null, CreateMode.PERSISTENT,
createCallback);
+ createCallback.waitForSuccess();
+ Assert.assertEquals(createCallback.getRc(), 0);
+
+ // try to create oversize node, should fail
+ zkClient.asyncCreate("/tmp/asyncOversize", oversizeZNRecord,
CreateMode.PERSISTENT,
+ createCallback);
+ createCallback.waitForSuccess();
+ Assert.assertEquals(createCallback.getRc(),
KeeperException.Code.MarshallingError);
+
+ ZNRecord normalZNRecord = new ZNRecord("normal");
+ normalZNRecord.setSimpleField("key", buf);
+
+
org.apache.helix.zookeeper.zkclient.callback.ZkAsyncCallbacks.SetDataCallbackHandler
+ setDataCallbackHandler = new
org.apache.helix.zookeeper.zkclient.callback.ZkAsyncCallbacks.SetDataCallbackHandler();
+ zkClient.asyncSetData("/tmp/async", normalZNRecord, -1,
setDataCallbackHandler);
+ setDataCallbackHandler.waitForSuccess();
+ Assert.assertEquals(setDataCallbackHandler.getRc(), 0);
+
+ zkClient.asyncSetData("/tmp/async", oversizeZNRecord, -1,
setDataCallbackHandler);
+ setDataCallbackHandler.waitForSuccess();
+ Assert.assertEquals(setDataCallbackHandler.getRc(),
KeeperException.Code.MarshallingError);
+ } finally {
+ if (originSizeLimit == null) {
+
System.clearProperty(ZkSystemPropertyKeys.ZK_SERIALIZER_ZNRECORD_WRITE_SIZE_LIMIT_BYTES);
+ } else {
+
System.setProperty(ZkSystemPropertyKeys.ZK_SERIALIZER_ZNRECORD_WRITE_SIZE_LIMIT_BYTES,
+ originSizeLimit);
+ }
+ zkClient.delete("/tmp/async");
+ zkClient.delete("/tmp/asyncOversize");
Review comment:
It has been taken care of by after method call. And if the delete fails,
there is nothing I can do except to fail the test. But it is not really this
test is testing for. So let's don't over test here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
