narendly commented on a change in pull request #844: Implement setRoutingData
for MetadataStoreDirectoryService
URL: https://github.com/apache/helix/pull/844#discussion_r386766157
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/metadatastore/ZkMetadataStoreDirectory.java
##########
@@ -262,17 +309,22 @@ public void refreshRoutingData(String namespace) {
if (!_routingZkAddressMap.containsKey(namespace)) {
LOG.error(
"Failed to refresh internally-cached routing data! Namespace not
found: " + namespace);
+ return;
}
+ Map<String, List<String>> rawRoutingData;
try {
- Map<String, List<String>> rawRoutingData =
- _routingDataReaderMap.get(namespace).getRoutingData();
+ rawRoutingData = _routingDataReaderMap.get(namespace).getRoutingData();
_realmToShardingKeysMap.put(namespace, rawRoutingData);
-
- MetadataStoreRoutingData routingData = new
TrieRoutingData(rawRoutingData);
- _routingDataMap.put(namespace, routingData);
} catch (InvalidRoutingDataException e) {
LOG.error("Failed to refresh cached routing data for namespace {}",
namespace, e);
+ return;
+ }
+
+ try {
+ _routingDataMap.put(namespace, new TrieRoutingData(rawRoutingData));
+ } catch (InvalidRoutingDataException e) {
+ // Do not create TrieRoutingData if the routing data is invalid
Review comment:
Probably a good idea to add a warn log here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
