pkuwm commented on a change in pull request #838: Make ConfigAccessor and
ZkUtil realm-aware
URL: https://github.com/apache/helix/pull/838#discussion_r386789989
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/api/client/RealmAwareZkClient.java
##########
@@ -325,16 +328,18 @@ public int hashCode() {
* ZkConnection-related configs for creating an instance of
RealmAwareZkClient.
*/
class RealmAwareZkConnectionConfig {
-
/**
* zkRealmShardingKey: used to deduce which ZK realm this
RealmAwareZkClientConfig should connect to.
- * NOTE: this field will be ignored if MODE is MULTI_REALM!
+ * NOTE: this field will be ignored if RealmMode is MULTI_REALM!
*/
- private final String _zkRealmShardingKey;
- private int _sessionTimeout = DEFAULT_SESSION_TIMEOUT;
-
- public RealmAwareZkConnectionConfig(String zkRealmShardingKey) {
- _zkRealmShardingKey = zkRealmShardingKey;
+ private String _zkRealmShardingKey;
+ private String _msdsEndpoint;
+ private int _sessionTimeout;
+
+ private RealmAwareZkConnectionConfig(Builder builder) {
+ _zkRealmShardingKey = builder._zkRealmShardingKey;
Review comment:
This “._” is a bit annoying and we may not have setters in builder...
This is one of the reasons I don’t like this leading underscore naming
convention. May be in this case I would just ignore this convention and instead
use a convention without leading underscore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
