narendly commented on a change in pull request #846: [WIP] Make ZKHelixAdmin
and ZKHelixManager Realm-aware
URL: https://github.com/apache/helix/pull/846#discussion_r387499467
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/FederatedZkClient.java
##########
@@ -79,7 +83,31 @@
private volatile boolean _isClosed;
private PathBasedZkSerializer _pathBasedZkSerializer;
+ public FederatedZkClient() {
+ this(new RealmAwareZkClient.RealmAwareZkClientConfig()
+ .setZkSerializer(new ZNRecordSerializer()));
+ }
+
// TODO: support capacity of ZkClient number in one FederatedZkClient and do
garbage collection.
+ public FederatedZkClient(RealmAwareZkClient.RealmAwareZkClientConfig
clientConfig) {
+ try {
Review comment:
FederatedZkClient should take in connectionConfig and clientConfig. I'll
just assume this is a placeholder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
