narendly commented on a change in pull request #855: Make ZkBaseDataAccessor
realm-aware
URL: https://github.com/apache/helix/pull/855#discussion_r387968735
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZkBaseDataAccessor.java
##########
@@ -1248,4 +1251,41 @@ public void close() {
_zkClient.close();
}
}
+
+ private RealmAwareZkClient buildRealmAwareZkClient(
+ RealmAwareZkClient.RealmAwareZkClientConfig clientConfig, String
zkAddress,
+ ZkClientType zkClientType) {
+ RealmAwareZkClient zkClient;
+
+ try {
+ zkClient = new FederatedZkClient(
+ new
RealmAwareZkClient.RealmAwareZkConnectionConfig.Builder().build(),
clientConfig);
+ } catch (IllegalStateException | IllegalArgumentException | IOException |
InvalidRoutingDataException e) {
Review comment:
Under what circumstances will `IllegalArgumentException` be thrown?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
