kaisun2000 commented on a change in pull request #836: Make MSDS endpoint
configurable for HttpRoutingDataReader
URL: https://github.com/apache/helix/pull/836#discussion_r388491900
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/util/HttpRoutingDataReader.java
##########
@@ -41,13 +42,17 @@
public class HttpRoutingDataReader {
- private static final String MSDS_ENDPOINT =
+ private static final String SYSTEM_MSDS_ENDPOINT =
System.getProperty(MetadataStoreRoutingConstants.MSDS_SERVER_ENDPOINT_KEY);
private static final int HTTP_TIMEOUT_IN_MS = 5000;
/** Double-checked locking requires that the following fields be volatile */
- private static volatile Map<String, List<String>> _rawRoutingData;
- private static volatile MetadataStoreRoutingData _metadataStoreRoutingData;
+ // The following map stands for (MSDS endpoint, Raw Routing Data)
+ private static volatile Map<String, Map<String, List<String>>>
_rawRoutingDataMap =
Review comment:
In fact, if my understanding is correct, we people use this one, for one
product, there is only one SYSTEM_MSDS_ENDPOINT would be defined. Say
storagesystem1, or storagesystem2. They can't co-exist. Put it another way,
this map the first key field would alway have only one value, right?
I guess the intention is that to make this httproutingdatareader servering
multiple namespaces (storagesystem1, storagesysgtem2). In reality, they would
still serve only one.
Or am I missing something here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
