mgao0 commented on issue #831: Generate cancellation message for currentState=null desiredState=DROPPED URL: https://github.com/apache/helix/pull/831#issuecomment-595404833 > I haven't finish reading details yet. Overall, when we try to move code to a separate method, try to simplify the logic and parameters as much as possible. What I observed here are very long parameter lists. Can we try to simplify it? > > Moreover, could you provide more details about the old behavior and the issue. Then compare it with the new one. Thanks. Good point. Please see the updated PR description, hope it explains the issue. Please let me know how I can improve it. Per your concerns about long parameter list, I have tried to simplify it and I think this is the best I can do right now. All the parameters are needed due to the complex logic, and the purpose of moving into a separate method is to avoid duplicated code because they will be called under two different conditions.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
