narendly commented on a change in pull request #859: Update customize state
using updater
URL: https://github.com/apache/helix/pull/859#discussion_r389920071
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/paticipant/TestCustomizedStateUpdate.java
##########
@@ -113,40 +143,176 @@ public void testUpdateCustomizedState() throws
Exception {
Map<String, String> stateMap2 = new HashMap<>();
stateMap2.put("PREVIOUS_STATE", "STARTED");
stateMap2.put("CURRENT_STATE", "END_OF_PUSH_RECEIVED");
- mockProvider.updateCustomizedState(CUSTOMIZE_STATE_NAME, RESOURCE_NAME,
PARTITION_NAME2,
- stateMap2);
+ _mockProvider
+ .updateCustomizedState(CUSTOMIZE_STATE_NAME, RESOURCE_NAME,
PARTITION_NAME2, stateMap2);
- customizedState = mockProvider.getCustomizedState(CUSTOMIZE_STATE_NAME,
RESOURCE_NAME);
+ customizedState = _mockProvider.getCustomizedState(CUSTOMIZE_STATE_NAME,
RESOURCE_NAME);
Assert.assertNotNull(customizedState);
Assert.assertEquals(customizedState.getId(), RESOURCE_NAME);
mapView = customizedState.getRecord().getMapFields();
Assert.assertEquals(mapView.keySet().size(), 2);
- Assert.assertEqualsNoOrder(mapView.keySet().toArray(), new String[] {
- PARTITION_NAME1, PARTITION_NAME2
- });
+ Assert.assertEqualsNoOrder(mapView.keySet().toArray(),
+ new String[]{PARTITION_NAME1, PARTITION_NAME2});
- Map<String, String> partitionMap1 = mockProvider
+ Map<String, String> partitionMap1 = _mockProvider
.getPerPartitionCustomizedState(CUSTOMIZE_STATE_NAME, RESOURCE_NAME,
PARTITION_NAME1);
Assert.assertEquals(partitionMap1.keySet().size(), 2);
Assert.assertEquals(partitionMap1.get("PREVIOUS_STATE"),
"END_OF_PUSH_RECEIVED");
Assert.assertEquals(partitionMap1.get("CURRENT_STATE"), "COMPLETED");
- Map<String, String> partitionMap2 = mockProvider
+ Map<String, String> partitionMap2 = _mockProvider
.getPerPartitionCustomizedState(CUSTOMIZE_STATE_NAME, RESOURCE_NAME,
PARTITION_NAME2);
Assert.assertEquals(partitionMap2.keySet().size(), 2);
Assert.assertEquals(partitionMap2.get("PREVIOUS_STATE"), "STARTED");
Assert.assertEquals(partitionMap2.get("CURRENT_STATE"),
"END_OF_PUSH_RECEIVED");
// test delete customized state for a partition
- mockProvider.deletePerPartitionCustomizedState(CUSTOMIZE_STATE_NAME,
RESOURCE_NAME,
- PARTITION_NAME1);
- customizedState = mockProvider.getCustomizedState(CUSTOMIZE_STATE_NAME,
RESOURCE_NAME);
+ _mockProvider
+ .deletePerPartitionCustomizedState(CUSTOMIZE_STATE_NAME,
RESOURCE_NAME, PARTITION_NAME1);
+ customizedState = _mockProvider.getCustomizedState(CUSTOMIZE_STATE_NAME,
RESOURCE_NAME);
Assert.assertNotNull(customizedState);
Assert.assertEquals(customizedState.getId(), RESOURCE_NAME);
mapView = customizedState.getRecord().getMapFields();
Assert.assertEquals(mapView.keySet().size(), 1);
Assert.assertEquals(mapView.keySet().iterator().next(), PARTITION_NAME2);
+ }
+
+ @Test
+ public void testUpdateSinglePartitionCustomizedState() {
+ _mockProvider.updateCustomizedState(CUSTOMIZE_STATE_NAME, RESOURCE_NAME,
PARTITION_NAME1,
+ PARTITION_STATE);
+
+ // get customized state
+ CustomizedState customizedState =
+ _mockProvider.getCustomizedState(CUSTOMIZE_STATE_NAME, RESOURCE_NAME);
+ Assert.assertEquals(
+
customizedState.getPartitionStateMap(CustomizedState.CustomizedStateProperty.CURRENT_STATE)
+ .size(), 1);
+ Map<String, String> map = new HashMap<>();
+ map.put(PARTITION_NAME1, null);
+ Assert.assertEquals(customizedState
+
.getPartitionStateMap(CustomizedState.CustomizedStateProperty.PREVIOUS_STATE),
map);
+ Assert.assertEquals(
+
customizedState.getPartitionStateMap(CustomizedState.CustomizedStateProperty.START_TIME),
+ map);
+ Assert.assertEquals(
+
customizedState.getPartitionStateMap(CustomizedState.CustomizedStateProperty.END_TIME),
+ map);
+ Assert.assertEquals(customizedState.getState(PARTITION_NAME1),
PARTITION_STATE);
+ Assert.assertNull(customizedState.getState(PARTITION_NAME2));
+ Assert.assertTrue(customizedState.isValid());
+
+ // get per partition customized state
+ map = new HashMap<>();
+ map.put(CustomizedState.CustomizedStateProperty.CURRENT_STATE.name(),
PARTITION_STATE);
+ Map<String, String> partitionCustomizedState = _mockProvider
+ .getPerPartitionCustomizedState(CUSTOMIZE_STATE_NAME, RESOURCE_NAME,
PARTITION_NAME1);
+ Assert.assertEquals(partitionCustomizedState, map);
+ Assert.assertNull(_mockProvider
+ .getPerPartitionCustomizedState(CUSTOMIZE_STATE_NAME, RESOURCE_NAME,
PARTITION_NAME2));
+ }
+
+ @Test
+ public void testUpdateSinglePartitionCustomizedStateWithNullField() {
+ _mockProvider
+ .updateCustomizedState(CUSTOMIZE_STATE_NAME, RESOURCE_NAME,
PARTITION_NAME1, (String) null);
+
+ // get customized state
+ CustomizedState customizedState =
+ _mockProvider.getCustomizedState(CUSTOMIZE_STATE_NAME, RESOURCE_NAME);
+ Map<String, String> map = new HashMap<>();
+ map.put(PARTITION_NAME1, null);
+ Assert.assertEquals(
+
customizedState.getPartitionStateMap(CustomizedState.CustomizedStateProperty.CURRENT_STATE),
+ map);
+ Assert.assertEquals(customizedState.getState(PARTITION_NAME1), null);
+ Assert.assertTrue(customizedState.isValid());
+
+ // get per partition customized state
+ map = new HashMap<>();
+ map.put(CustomizedState.CustomizedStateProperty.CURRENT_STATE.name(),
null);
+ Map<String, String> partitionCustomizedState = _mockProvider
+ .getPerPartitionCustomizedState(CUSTOMIZE_STATE_NAME, RESOURCE_NAME,
PARTITION_NAME1);
+ Assert.assertEquals(partitionCustomizedState, map);
+ Assert.assertNull(_mockProvider
+ .getPerPartitionCustomizedState(CUSTOMIZE_STATE_NAME, RESOURCE_NAME,
PARTITION_NAME2));
+ }
+
+ @Test
+ public void testUpdateCustomizedStateWithEmptyMap() {
+ _mockProvider.updateCustomizedState(CUSTOMIZE_STATE_NAME, RESOURCE_NAME,
PARTITION_NAME1,
+ new HashMap<>());
+
+ // get customized state
+ CustomizedState customizedState =
+ _mockProvider.getCustomizedState(CUSTOMIZE_STATE_NAME, RESOURCE_NAME);
+ Assert.assertNull(customizedState.getState(PARTITION_NAME1));
+ Map<String, String> partitionStateMap =
+
customizedState.getPartitionStateMap(CustomizedState.CustomizedStateProperty.CURRENT_STATE);
+ Assert.assertNotNull(partitionStateMap);
+ Assert.assertTrue(partitionStateMap.containsKey(PARTITION_NAME1));
+ Assert.assertNull(partitionStateMap.get(PARTITION_NAME1));
+ Assert.assertNull(customizedState.getState(PARTITION_NAME1));
+ Assert.assertFalse(partitionStateMap.containsKey(PARTITION_NAME2));
+ Assert.assertTrue(customizedState.isValid());
+
+ // get per partition customized state
+ Map<String, String> partitionCustomizedState = _mockProvider
+ .getPerPartitionCustomizedState(CUSTOMIZE_STATE_NAME, RESOURCE_NAME,
PARTITION_NAME1);
+ Assert.assertEquals(partitionCustomizedState.size(), 0);
+ Assert.assertNull(_mockProvider
+ .getPerPartitionCustomizedState(CUSTOMIZE_STATE_NAME, RESOURCE_NAME,
PARTITION_NAME2));
+ }
+
+ @Test
+ public void testDeleteNonExistingPerPartitionCustomizedState() {
+ _mockProvider.updateCustomizedState(CUSTOMIZE_STATE_NAME, RESOURCE_NAME,
PARTITION_NAME1,
+ PARTITION_STATE);
+ _mockProvider
+ .deletePerPartitionCustomizedState(CUSTOMIZE_STATE_NAME,
RESOURCE_NAME, PARTITION_NAME2);
+ Assert.assertNotNull(_mockProvider
+ .getPerPartitionCustomizedState(CUSTOMIZE_STATE_NAME, RESOURCE_NAME,
PARTITION_NAME1));
+ Assert.assertNull(_mockProvider
+ .getPerPartitionCustomizedState(CUSTOMIZE_STATE_NAME, RESOURCE_NAME,
PARTITION_NAME2));
+ }
+
+ @Test
+ public void testSimultaneousUpdateCustomizedState() {
+ int n = 10;
Review comment:
Not a good idea to use 'n's like this - please either make it a int constant
or make it more descriptive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
