NealSun96 opened a new issue #879: Fix testInstancesStoppable_zoneBased URL: https://github.com/apache/helix/issues/879 The changes merged in https://github.com/apache/helix/pull/858 broke `testInstancesStoppable_zoneBased`. The test didn't create external views at all, which will encounter exceptions with the new logic. The logic added wasn't supposed to break the tests because the logic is to perform null checks before an if condition that utilizes maps. However, the tests were passing because in the "and" if condition, it failed at `isPartitionMap.containsKey(instanceName)` without accessing the second part of the "and" condition. Therefore, even though the second part could cause an null pointer failure, it was never an issue. The fix is to reorder the logic such that the conditions are performed separately with null checks right before each map access.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
