pkuwm commented on a change in pull request #846: Make ZKHelixAdmin and
ZKHelixManager Realm-aware
URL: https://github.com/apache/helix/pull/846#discussion_r391406024
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java
##########
@@ -1285,4 +1266,60 @@ public void handleSessionEstablishmentError(Throwable
error) throws Exception {
public Long getSessionStartTime() {
return _sessionStartTime;
}
+
+ private RealmAwareZkClient createSingleRealmZkClient() {
Review comment:
- `prepareAndGet` sounds like a method does 2 things. I prefer to name a
method which does one thing. `get` is better than `prepareAndGet` as there is
no need to care about "prepare" since the final purpose is "get". There is
already one method `createClient()` so I prefer to keep the name.
- It is a private method and the logic is pretty straightforward. That's why
I didn't consider adding comments. Anyway, since you suggested here, added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
