pkuwm commented on a change in pull request #851: Add customized view
computation and modify Helix generic controller to include new stage
URL: https://github.com/apache/helix/pull/851#discussion_r394043654
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -1233,4 +1316,24 @@ private void initPipeline(Thread eventThread,
BaseControllerDataProvider cache)
eventThread.setDaemon(true);
eventThread.start();
}
+
+ private List<String> getEnabledCustomizedStates(HelixManager manager) {
+ CustomizedStateConfig customizedStateConfig =
+ manager.getConfigAccessor().getCustomizedStateConfig(_clusterName);
+ if (customizedStateConfig != null) {
+ return customizedStateConfig.getAggregationEnabledTypes();
+ }
+ return new ArrayList<>();
Review comment:
`Collections.emptyList()` may be more lightweight as a returning empty list?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
