pkuwm opened a new pull request #911: Fix TestZNRecordSerializeWriteSizeLimit
   ### Issues
   - [ ] My PR addresses the following Helix issues and references them in the 
PR description:
   Fixes #910 
   ### Description
   - [ ] Here are some details about my PR, including screenshots of any UI 
   There was a exception type change in znrecord serializers: ZkClientException 
-> ZkMarshallingError. So the exception types don't match in the unit test.
   This PR fixes this issue by changing the expected exception type in the unit 
   ### Tests
   - [ ] The following tests are written for this issue:
   (List the names of added unit/integration tests)
   - [ ] The following is the result of the "mvn test" command on the 
appropriate module:
   ### Commits
   - [ ] My commits all reference appropriate Apache Helix GitHub issues in 
their subject lines. In addition, my commits follow the guidelines from "[How 
to write a good git commit message](":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   ### Documentation (Optional)
   - [ ] In case of new functionality, my PR adds documentation in the 
following wiki page:
   (Link the GitHub wiki you added)
   ### Code Quality
   - [ ] My diff has been formatted using helix-style.xml 
   (helix-style-intellij.xml if IntelliJ IDE is used)

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to