zhangmeng916 commented on a change in pull request #912: Add integration test
to customized view aggregation
URL: https://github.com/apache/helix/pull/912#discussion_r398322393
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/TestCustomizedViewAggregation.java
##########
@@ -0,0 +1,404 @@
+package org.apache.helix.integration;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Date;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.TreeMap;
+
+import com.google.common.collect.Maps;
+import org.apache.helix.HelixDataAccessor;
+import org.apache.helix.HelixManager;
+import org.apache.helix.HelixManagerFactory;
+import org.apache.helix.InstanceType;
+import org.apache.helix.PropertyType;
+import org.apache.helix.TestHelper;
+import org.apache.helix.ZNRecord;
+import org.apache.helix.ZkUnitTestBase;
+import org.apache.helix.customizedstate.CustomizedStateProvider;
+import org.apache.helix.customizedstate.CustomizedStateProviderFactory;
+import org.apache.helix.integration.manager.ClusterControllerManager;
+import org.apache.helix.integration.manager.MockParticipantManager;
+import org.apache.helix.model.CustomizedStateConfig;
+import org.apache.helix.model.CustomizedView;
+import org.apache.helix.spectator.RoutingTableProvider;
+import org.apache.helix.spectator.RoutingTableSnapshot;
+import org.testng.Assert;
+import org.testng.annotations.AfterClass;
+import org.testng.annotations.BeforeClass;
+import org.testng.annotations.Test;
+
+
+public class TestCustomizedViewAggregation extends ZkUnitTestBase {
+
+ private static CustomizedStateProvider _customizedStateProvider_participant0;
+ private static CustomizedStateProvider _customizedStateProvider_participant1;
+ private static RoutingTableProvider _routingTableProvider;
+ private static HelixManager _spectator;
+ private static HelixManager _manager;
+ // 1st key: customized state type, 2nd key: resource name, 3rd key:
partition name, 4th key: instance name, value: state value
+ // This map contains all the customized state information that is enabled
for aggregation in config, including those are not listened by routing table
provider
+ private static Map<String, Map<String, Map<String, Map<String, String>>>>
_localCustomizedView;
+ // The set contains customized state types that are listened by routing
table provider
+ private static Set<String> _localVisibleCustomizedStateType;
+ private String INSTANCE_0;
Review comment:
Let's try to make the naming convention more standard. It should have the
type + number, and the number should start from 0 instead of 1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
