zhangmeng916 commented on a change in pull request #944: Add CustomizedView 
Root Change Listener to the Router
URL: https://github.com/apache/helix/pull/944#discussion_r406858418
 
 

 ##########
 File path: 
helix-core/src/main/java/org/apache/helix/spectator/RoutingTableProvider.java
 ##########
 @@ -683,6 +694,27 @@ public void onCustomizedViewChange(List<CustomizedView> 
customizedViewList,
     }
   }
 
+  @Override
+  @PreFetch(enabled = false)
+  public void onCustomizedViewRootChange(List<String> customizedViewTypes,
 
 Review comment:
   So the prefetched type is not used anywhere. I think we should add listeners 
to the intersection of the available types and the user required types, right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to