narendly opened a new pull request #945: Change thread pool used for TTL-based GC in ZkBucketDataAccessor URL: https://github.com/apache/helix/pull/945 ### Issues - [x] My PR addresses the following Helix issues and references them in the PR description: Fixes #767 ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: ZkBucketDataAccessor supports TTL-based garbage collection of stale versions. We create a thread pool for this of size 1, but the way the thread pool is created currently may not guarantee strictly sequential execution of GC timer tasks, which may cause unexpected GC behaviors. This commit uses Executors.newSingleThreadScheduledExecutor()to create the GC thread pool with a sequential execution guarantee. Note: another way to do this is to implement a Bounded event queue-based GC, but Java already provides this queue-based model in Executors interface - we want to try our best at avoid reinventing the wheel. ### Tests - [x] The following tests are written for this issue: TestWagedRebalancer, TestZkBucketDataAccessor, etc. - [x] The following is the result of the "mvn test" command on the appropriate module: helix-core: (PENDING) ### Commits - [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - [x] My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
