NealSun96 commented on a change in pull request #955: Fix MSD routing data
refreshing for update methods
URL: https://github.com/apache/helix/pull/955#discussion_r409090040
##########
File path:
helix-rest/src/test/java/org/apache/helix/rest/metadatastore/TestZkMetadataStoreDirectory.java
##########
@@ -344,6 +345,10 @@ public void testDataDeletionCallback() throws Exception {
+ " contains either empty or invalid routing data!")) {
return false;
}
+ } catch (IllegalArgumentException iae) {
+ if (!iae.getMessage().equals("Provided path is not a valid Zookeeper
path: anyKey")) {
+ return false;
Review comment:
I see your point now, thanks for the explanation. Was this test case flaky
because of that? This is a very good catch! 👍
I think it makes more sense to replace "anyKey" with an actual existing key
in the routing data; the handling of `IllegalArgumentException` is only caused
by "anyKey", and is not what this test case should focus on. My point is that
using "anyKey" is a mistake. We shouldn't change the test case to accommodate
that mistake; we can just correct it by using something like
`TEST_SHARDING_KEYS`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
