narendly commented on a change in pull request #959:
URL: https://github.com/apache/helix/pull/959#discussion_r411687393
##########
File path:
helix-rest/src/test/java/org/apache/helix/rest/server/TestResourceAccessor.java
##########
@@ -657,19 +660,9 @@ private void createDummyMapping(String clusterName, String
resourceName,
System.out.println("End test :" + TestHelper.getTestMethodName());
}
- private void stopClustersControllers() {
- for (ClusterControllerManager cm : _clusterControllerManagers) {
- if (cm != null && cm.isConnected()) {
- cm.syncStop();
- }
- }
+ private void enableCluster(String clusterName, boolean enable) {
+ HelixAdmin helixAdmin = new ZKHelixAdmin(_gZkClient);
+ helixAdmin.enableCluster(clusterName, enable);
Review comment:
Why do you need to create a HelixAdmin object every time this is called?
Also, why do you need to wrap this into a private method especially when the
function signatures are _exactly the same_?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
