mgao0 opened a new pull request #961: URL: https://github.com/apache/helix/pull/961
### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: Current DistributedLock interface API names can be confusing for users, since they are not following java convention. For example: we have acquireLock for both blocking (wait until the lock is release to acquire the lock) and nonblocking locks (return result immediately when called to acquire the lock). ### Description - [ ] Here are some details about my PR, including screenshots of any UI changes: API changes: acquireLock -> tryLock: nonblocking lock releaseLock -> unlock API not included in this PR: aquireLock -> lock: blocking lock This API is not included in the interface yet, because it is not in the current scope. The API is written here so it is clear that now we will be able to have two different APIs to acquire the lock according to different mechanism. Also this PR changed some imports for ZooKeeper related APIs because we have a separate module for ZK APIs now. ### Tests - [ ] The following is the result of the "mvn test" command on the appropriate module: [INFO] Results: [INFO] [ERROR] Failures: [ERROR] TestStateTransitionTimeoutWithResource.testStateTransitionTimeOut:171 expected:<true> but was:<false> [INFO] [ERROR] Tests run: 1122, Failures: 1, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:13 h [INFO] Finished at: 2020-04-22T16:02:23-07:00 [INFO] ------------------------------------------------ ### Commits - [ ] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation (Optional) - [ ] In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Code Quality - [ ] My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
