mgao0 opened a new pull request #964: URL: https://github.com/apache/helix/pull/964
### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: This PR adds a distributed lock module into Helix. ### Description - [ ] Here are some details about my PR, including screenshots of any UI changes: - Non blocking lock implementation. It creates an API to acquire the lock that will immediately return true if it's successfully acquired, or false if not. Also an API to unlock the lock is provded. - Timeout support. The client need to input the timeout when it tries to acquire the lock. After timeout, if no other client tries to get the lock, the client can still keep the lock, if other client tries to acquire the lock, and finds the previous client already timeout, the previous client will be forced to release the lock. - Lock message support. The client can input the reason for the lock (a string) when it tries to acquire the lock, and future lock operation, when fails, will get the message for the current lock. - Java API support. ### Tests - [ ] The following tests are written for this issue: TestZKHelixNonblockingLock.java - [ ] The following is the result of the "mvn test" command on the appropriate module: [INFO] Results: [INFO] [ERROR] Failures: [ERROR] TestStateTransitionTimeoutWithResource.testStateTransitionTimeOut:171 expected: but was: [INFO] [ERROR] Tests run: 1122, Failures: 1, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:13 h [INFO] Finished at: 2020-04-22T16:02:23-07:00 [INFO] ------------------------------------------------ ### Commits - [ ] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - [ ] My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
