jiajunwang opened a new pull request #970: URL: https://github.com/apache/helix/pull/970
### Issues - [X] My PR addresses the following Helix issues and references them in the PR description: #969 ### Description - [ ] Here are some details about my PR, including screenshots of any UI changes: If any exceptions happen during the async call, the current design will fail the operation and may eventually return a partial result. This change makes the ZkClient retry operation if the error is because of a temporary ZK connection issue (CONNECTIONLOSS, OPERATIONTIMEOUT. SESSIONEXPIRED, SESSIONMOVED). So the async call has a larger chance to finish the operation. Note that if the exception is due to business logic, the async call will still fail and the right return code will be sent to the callback handler. TODO: 1. Unit test 2. Need to clean up the pending retry request when ZkClient is closed. ### Tests - [X] The following tests are written for this issue: [INFO] Results: [INFO] [ERROR] Failures: [ERROR] TestWorkflowTimeout.testWorkflowTimeoutWhenWorkflowCompleted:116 expected:<true> but was:<false> [INFO] [ERROR] Tests run: 1144, Failures: 1, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:19 h [INFO] Finished at: 2020-04-23T15:13:16-07:00 [INFO] ------------------------------------------------------------------------ Rerun: [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 18.551 s - in org.apache.helix.integration.task.TestWorkflowTimeout [INFO] [INFO] Results: [INFO] [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 24.830 s [INFO] Finished at: 2020-04-23T16:22:29-07:00 [INFO] ------------------------------------------------------------------------ - [ ] The following is the result of the "mvn test" command on the appropriate module: TBD ### Commits - [X] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation (Optional) - [ ] In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Code Quality - [X] My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
