jiajunwang commented on a change in pull request #976:
URL: https://github.com/apache/helix/pull/976#discussion_r417011319
##########
File path:
helix-core/src/test/java/org/apache/helix/manager/zk/TestZNRecordSizeLimit.java
##########
@@ -86,8 +89,8 @@ public void testZNRecordSizeLimitUseZNRecordSerializer() {
_gZkClient.createPersistent(path2, true);
try {
_gZkClient.writeData(path2, largeRecord);
- } catch (HelixException e) {
- Assert.fail("Should not fail because data size is larger than 1M since
compression applied");
+ } catch (ZkMarshallingError e) {
Review comment:
I don't have a strong preference here. But I think it is redundant
try-catch. Otherwise, why we are not adding this try-catch then throw exception
blocks to all the test code? Because all test code, as long as it is not
testing for the negative cases, will have the same assumption that we shall not
have a certain Exception thrown.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
