lei-xia commented on a change in pull request #974:
URL: https://github.com/apache/helix/pull/974#discussion_r420313803



##########
File path: helix-core/src/main/java/org/apache/helix/BaseDataAccessor.java
##########
@@ -166,6 +167,7 @@
    * @param options Set the type of ZNode see the valid values in {@link 
AccessOption}
    * @return A list of children of the parent ZNode
    */
+  @Deprecated
   List<T> getChildren(String parentPath, List<Stat> stats, int options);
 
   /**

Review comment:
       What is the unit of retryInterval, second or millisecond?  Should be use 
long?  Usually have three consecutive parameters with the same type is not easy 
to use. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to