NealSun96 opened a new pull request #1011: URL: https://github.com/apache/helix/pull/1011
### Issues - [x] My PR addresses the following Helix issues and references them in the PR description: Fixes #1010 ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: With the recent changes of configurable thread pool size, we need to allow users to modify the "target thread pool sizes" that will be used to construct task thread pools. We are adding CRUD endpoints to TaskDriver that support "setting target thread pool sizes", "getting target thread pool sizes", "setting global target thread pool sizes", "getting global target thread pool sizes", and "getting current thread pool sizes". ### Tests - [x] The following is the result of the "mvn test" command on the appropriate module: ``` [INFO] Results: [INFO] [ERROR] Failures: [ERROR] TestEnableCompression.testEnableCompressionResource:117 expected:<true> but was:<false> [ERROR] TestCrossClusterMessagingService.TestMessageSimpleSendReceiveAsync:143 [ERROR] TestStateTransitionTimeout.testStateTransitionTimeOut:166 expected:<true> but was:<false> [ERROR] TestStateTransitionTimeoutWithResource.testStateTransitionTimeOut:171 expected:<true> but was:<false> [ERROR] TestStateTransitionTimeoutWithResource.testStateTransitionTimeoutByClusterLevel:196 expected:<true> but was:<false> [ERROR] TestZkCacheAsyncOpSingleThread.testHappyPathExtOpZkCacheBaseDataAccessor:214 zkCache doesn't match data on Zk expected:<true> but was:<false> [INFO] [ERROR] Tests run: 1169, Failures: 6, Errors: 0, Skipped: 1 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:15 h [INFO] Finished at: 2020-05-14T16:18:58-07:00 [INFO] ------------------------------------------------------------------------ ``` Rerun failed tests ``` [INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 81.366 s - in TestSuite [INFO] [INFO] Results: [INFO] [INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:26 min [INFO] Finished at: 2020-05-14T16:23:04-07:00 [INFO] ------------------------------------------------------------------------ ``` ### Commits - [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - [x] My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
