narendly commented on a change in pull request #1000:
URL: https://github.com/apache/helix/pull/1000#discussion_r426839880
##########
File path:
helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
##########
@@ -714,7 +724,7 @@ private void syncSessionToController(HelixManager manager) {
@Override
@PreFetch(enabled = false)
- public void onMessage(String instanceName, List<Message> messages,
+ public synchronized void onMessage(String instanceName, List<Message>
messages,
Review comment:
If we make sure periodic refresh timer is reset whenever there's been
recent events, this sort of synchronization won't be necessary by design. See
my more detailed comment below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
