pkuwm commented on a change in pull request #1007:
URL: https://github.com/apache/helix/pull/1007#discussion_r426848159
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java
##########
@@ -573,35 +618,36 @@ public void resetPartition(String clusterName, String
instanceName, String resou
// check the instance is alive
LiveInstance liveInstance =
accessor.getProperty(keyBuilder.liveInstance(instanceName));
if (liveInstance == null) {
- throw new HelixException(
- "Can't reset state for " + resourceName + "/" + partitionNames + "
on " + instanceName
- + ", because " + instanceName + " is not alive");
+ // check if the instance has never exist in the cluster
+ String instancePath = PropertyPathBuilder.instance(clusterName,
instanceName);
+ if (!_zkClient.exists(instancePath)) {
+ throw new HelixException(
+ resetPartitionLogHelper(clusterName, instanceName, resourceName,
partitionNames, null,
+ ResetPartitionFailureReason.INSTANCE_NOTALIVE));
+ } else {
+ throw new HelixException(
+ resetPartitionLogHelper(clusterName, instanceName, resourceName,
partitionNames, null,
+ ResetPartitionFailureReason.INSTANCE_NONEXISTENT));
Review comment:
Nit, just about style :) To reduce the duplicate code, I would do
something like this
```
String failureReason = _zkClient.exists(instancePath) ?
ResetPartitionFailureReason.INSTANCE_NONEXISTENT) :
ResetPartitionFailureReason.INSTANCE_NOTALIVE);
throw new HelixException(...);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
