pkuwm commented on a change in pull request #1016:
URL: https://github.com/apache/helix/pull/1016#discussion_r426967132
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/factory/ZkConnectionManager.java
##########
@@ -118,7 +118,7 @@ public void close() {
protected synchronized void close(boolean skipIfWatched) {
cleanupInactiveWatchers();
- if (_sharedWatchers.size() > 0) {
+ if (_sharedWatchers != null && _sharedWatchers.size() > 0) {
Review comment:
Synced offline. I missed the point ZkConnectionManager is managing
connection. So there is a wait in ZkClient.
This NPE is thrown when ZkConnectionManager is being constructed and
connection is not able to connect to ZK within timeout.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
