alirezazamani commented on a change in pull request #1013:
URL: https://github.com/apache/helix/pull/1013#discussion_r428777842
##########
File path:
helix-rest/src/test/java/org/apache/helix/rest/client/TestCustomRestClient.java
##########
@@ -145,6 +148,35 @@ public void testPostRequestFormat() throws IOException {
Assert.assertEquals(json.get("data").asText(), "{}");
}
+ @Test
+ public void testGetInstanceStoppableCheckSmallTimeout() throws Exception {
+ // Reset the INSTANCE in CustomRestClientFactory to create new one with
new TimeOut
+ Field instance =
CustomRestClientFactory.class.getDeclaredField("INSTANCE");
+ instance.setAccessible(true);
+ instance.set(null, null);
+
+ // Set 1 ms to cause timeout for http requests
+ System.setProperty(RestSystemPropertyKeys.HTTP_TIMEOUT_MS, "1");
+ // a popular echo server that echos all the inputs
+ // TODO: add a mock rest server
+ final String echoServer = "http://httpbin.org/post";;
+ CustomRestClient _customRestClient = CustomRestClientFactory.get();
+ boolean timeoutExceptionHappened = false;
+ try {
+ _customRestClient.getInstanceStoppableCheck(echoServer,
Collections.emptyMap());
+ } catch (ConnectTimeoutException e) {
+ // Since the timeout is so small, we are expecting to get
ConnectTimeoutException
+ timeoutExceptionHappened = true;
+ }
+ // Reset the HTTP_REQUEST_TIMEOUT property back to the default value
+ System.setProperty(RestSystemPropertyKeys.HTTP_TIMEOUT_MS, "60000");
Review comment:
Removed this test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
