narendly commented on pull request #1033: URL: https://github.com/apache/helix/pull/1033#issuecomment-635553574
Here's the copy of an offline discussion > Jiajun Wang:man-woman-girl-girl: 12:27 > Meng will confirm. But I think that scenario was discussed and address in the original design. > 12:28 > I will suggest keeping the root path listener (default feature for the new version controller) but the children's paths listeners will depend on the configuration. > > > > > > 12:29 > that is the minimum code change and logic is the simpliest. > 12:30 > Basically, we only need to avoid the default subscription to children nodes in the root path subscribe process (edited) > > Hunter Lee 12:30 > So are we comfortable with creating CallbackHandlers for nonexistent root paths? > > Jiajun Wang 12:30 > Then all the rest parts have been handled by the current code. > New > 12:32 > @hulee That's the only downside. But my argument is that: > It is a default feature for the new controller. > It won't cause watcher leakage. It is always associated with a live callback handler, although never triggered, > The new participant will always have this folder. That's the agreement. > 12:33 > The alternative design will create many additional codes for the "perfect" backward compatibility. > 12:33 > Which is not necessary IMO > > Hunter Lee 12:35 > Ok. Although not perfect, I think that approach strikes the right balance ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
