narendly commented on a change in pull request #1037:
URL: https://github.com/apache/helix/pull/1037#discussion_r432633442
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/rebalancer/TestAbnormalStatesResolver.java
##########
@@ -64,4 +80,101 @@ public void testConfigureResolver() {
clusterConfig.setAbnormalStateResolverMap(Collections.emptyMap());
configAccessor.setClusterConfig(CLUSTER_NAME, clusterConfig);
}
+
+ @Test(dependsOnMethods = "testConfigureResolver")
+ public void testExcessiveTopStateResolver() {
+ BestPossibleExternalViewVerifier verifier =
+ new
BestPossibleExternalViewVerifier.Builder(CLUSTER_NAME).setZkClient(_gZkClient).build();
+ Assert.assertTrue(verifier.verify(5000));
Review comment:
Use a constant instead of 5000? TestHelper has a constant value built-in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
