alirezazamani opened a new pull request #1040: URL: https://github.com/apache/helix/pull/1040
### Issues - [x] My PR addresses the following Helix issues and references them in the PR title: Fixes #1039 ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: The processTaskWithPendingMessage method is relying on the previousAssignment. In this PR, this method has been modified and previousAssignment has been replaced with currentState. ### Tests - [x] The following tests are written for this issue: TestUpdatePreviousAssignedTaskStatusWithPendingMessage - [x] The following is the result of the "mvn test" command on the appropriate module: Helix-Core: ``` [ERROR] Tests run: 1146, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 5,255.063 s <<< FAILURE! - in TestSuite [ERROR] testJobQueueAutoCleanUp(org.apache.helix.integration.task.TestJobQueueCleanUp) Time elapsed: 300.012 s <<< FAILURE! org.testng.internal.thread.ThreadTimeoutException: Method org.testng.internal.TestNGMethod.testJobQueueAutoCleanUp() didn't finish within the time-out 300000 [INFO] [INFO] Results: [INFO] [ERROR] Failures: [ERROR] TestJobQueueCleanUp.testJobQueueAutoCleanUp ยป ThreadTimeout Method org.testng.... [INFO] [ERROR] Tests run: 1146, Failures: 1, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:27 h [INFO] Finished at: 2020-05-29T14:14:16-07:00 [INFO] ------------------------------------------------------------------------ ``` The failed tests have passed when I ran them individually. mvn test -Dtest="TestJobQueueCleanUp" ``` [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 16.521 s - in org.apache.helix.integration.task.TestJobQueueCleanUp [INFO] [INFO] Results: [INFO] [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 22.301 s [INFO] Finished at: 2020-05-29T14:38:54-07:00 [INFO] ------------------------------------------------------------------------ ``` Helix-rest: ``` [INFO] Tests run: 159, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 41.274 s - in TestSuite [INFO] [INFO] Results: [INFO] [INFO] Tests run: 159, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 46.810 s [INFO] Finished at: 2020-05-29T14:40:07-07:00 [INFO] ------------------------------------------------------------------------ ``` ### Commits - [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - [x] My diff has been formatted using helix-style.xml ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
