xyuanlu opened a new issue #1042:
URL: https://github.com/apache/helix/issues/1042


   Helix does not check if an instance's topology config is defined correctly 
when the instance is added or joins cluster. This will cause Helix to fail the 
rebalance. We could add the sanity check when 
       1. Instance is added to the cluster,
       2. Instance joins cluster,
       3. User update InstanceConfig.
       4. Controller prepares the topology structure for rebalance   <-- 
Currently we only check here
       
   Since we already have sanity check logic in 
controller/rebalancer/topology/Topology.java and 
controller/rebalancer/waged/model/AssignableNode.java, it's better to extract 
the logic into an util function first and use the same logic to do sanity check 
in multiple places. 
   
   
   
   Reference: 
https://cwiki.apache.org/confluence/display/HELIX/Helix+Topology-aware+Rebalance+Strategy#HelixTopology-awareRebalanceStrategy-TopologyInformation
   
    


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to