jiajunwang commented on a change in pull request #1007:
URL: https://github.com/apache/helix/pull/1007#discussion_r433491425
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java
##########
@@ -560,6 +560,28 @@ private void processMaintenanceMode(String clusterName,
final boolean enabled,
}
}
+ private enum ResetPartitionFailureReason {
+ INSTANCE_NOT_ALIVE("%s is not alive in cluster %s"),
+ INSTANCE_NON_EXISTENT("%s does not exist in cluster %s"),
+ RESOURCE_NON_EXISTENT("resource %s is not added to cluster %s"),
+ PARTITION_NON_EXISTENT("not all %s exist in cluster %s"),
+ PARTITION_NOT_ERROR("%s is NOT found in cluster %s"),
+ STATE_MODEL_NON_EXISTENT("%s is NOT found in cluster %s"),
+ PENDING_MSG("a pending message %s exists for resource %s");
Review comment:
Let's don't bother including PENDING_MSG here. This is not compatible
with the other types. And if there is no other better way, we should not be
blocked on this.
Just leave it as it originally be.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
