jiajunwang commented on a change in pull request #1035:
URL: https://github.com/apache/helix/pull/1035#discussion_r433544784
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java
##########
@@ -212,6 +213,11 @@ protected ZkClient(IZkConnection zkConnection, int
connectionTimeout, long opera
}
public List<String> subscribeChildChanges(String path, IZkChildListener
listener) {
+ RealmAwareZkClient.ChildrenSubscribeResult result =
subscribeChildChanges(path, listener, false);
+ return result.children;
+ }
+
+ public RealmAwareZkClient.ChildrenSubscribeResult
subscribeChildChanges(String path, IZkChildListener listener, boolean
skipWatchingNodeNotExist) {
Review comment:
Let's make ChildrenSubscribeResult a standalone class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
