mgao0 commented on pull request #1049: URL: https://github.com/apache/helix/pull/1049#issuecomment-637871010
> > Looks good to me in general. I just wonder what is the chance that the content is in ZNRecord format. Which would be safer (true or false) as the default value for "isZNRecord"? > > isZNRecord = true would be safer because it would fail early in the chance that the content passed in is binary data. > > Could you approve the PR if you think it's good? :) Seems that I don't have write access. So you'll need to find someone else to approve it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
