jiajunwang opened a new pull request #1059: URL: https://github.com/apache/helix/pull/1059
### Issues - [X] My PR addresses the following Helix issues and references them in the PR description: #1028 ### Description - [X] Here are some details about my PR, including screenshots of any UI changes: Add a monitor wrapper class so that the abnormal state resolver reports the abnormal states detected and the recovery attempt count. Example ObjectName of the new monitor MBean: Rebalancer:ClusterName=<clusterName>, EntityName=AbnormalStates.<StateModelDefName> Attributes, 1. AbnormalStatePartitionCounter: record the total count of the partitions that has been found in abnormal status. Note that if one partition has been found to be abnormal twice, then we will record it twice in this counter as well. 2. RecoveryAttemptCounter: record the total count of succuessful recovery computation that has been done by the resolver. ### Tests - [X] The following tests are written for this issue: TestAbnormalStatesResolverMonitor - [ ] The following is the result of the "mvn test" command on the appropriate module: Running... ### Commits - [X] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation (Optional) - [ ] In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Code Quality - [X] My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
