kaisun2000 commented on a change in pull request #1035:
URL: https://github.com/apache/helix/pull/1035#discussion_r435565886
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java
##########
@@ -555,7 +569,11 @@ private void subscribeDataChange(String path,
NotificationContext.Type callbackT
logger.debug(_manager.getInstanceName() + " subscribe data-change.
path: " + path
+ ", listener: " + _listener);
}
- _zkClient.subscribeDataChanges(path, this);
+ boolean rt = _zkClient.subscribeDataChanges(path, this, callbackType !=
Type.INIT);
+ logger.debug("CallbackHandler {} subscribe data path {} result {}",
this, path, rt);
+ if (!rt) {
+ logger.info("CallbackHandler {} subscribe data path {} failed!", this,
path);
Review comment:
As I commented before, it is ok to be returning false here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
