jiajunwang opened a new pull request #1065: URL: https://github.com/apache/helix/pull/1065
### Issues - [X] My PR addresses the following Helix issues and references them in the PR description: #1063 ### Description - [X] Here are some details about my PR, including screenshots of any UI changes: Cluster topology fields are considered as the fundamental attributes of the cluster. For example, instance capacity, resource partition count, partition weight, etc. If the topology related fields are updated, the WAGED rebalancer will trigger the global rebalance process. Otherwise, the rebalancer will only do local (limited) rebalance to avoid unexpected partition movements. This change introduces HelixProperty Trimmer to filter out the non-topology related fields so the changes in those fields won't trigger the global rebalancing. ### Tests - [X] The following tests are written for this issue: TestHelixPropoertyTimmer - [ ] The following is the result of the "mvn test" command on the appropriate module: [INFO] [INFO] Results: [INFO] [ERROR] Failures: [ERROR] TestPartitionMovementThrottle.testResourceThrottle:161->getMaxParallelTransitionCount:375 ยป ConcurrentModification [ERROR] TestWorkflowTermination.testWorkflowRunningTimeout:131->verifyWorkflowCleanup:257 expected:<true> but was:<false> [ERROR] TestWorkflowTimeout.testWorkflowTimeoutWhenWorkflowCompleted:116 expected:<true> but was:<false> [INFO] [ERROR] Tests run: 1150, Failures: 3, Errors: 0, Skipped: 1 Rerun, [INFO] Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 95.276 s - in TestSuite [INFO] [INFO] Results: [INFO] [INFO] Tests run: 14, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:41 min [INFO] Finished at: 2020-06-04T11:01:27-07:00 [INFO] ------------------------------------------------------------------------ ### Commits - [X] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation (Optional) - [ ] In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Code Quality - [X] My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
