dasahcc commented on a change in pull request #1064:
URL: https://github.com/apache/helix/pull/1064#discussion_r435660239
##########
File path: helix-core/src/main/java/org/apache/helix/task/TaskDriver.java
##########
@@ -403,6 +403,14 @@ public void enqueueJobs(final String queue, final
List<String> jobs,
}
}
+ // Fail the operation if adding new jobs will cause the queue to reach its
capacity limit
Review comment:
It solved part of the problem. I think it still could cause race
condition when there is another thread submitting jobs. We should make this
operation as a transaction. It means when we update the Workflow Config with
job dag. If it exceeds the capacity, we should remove all the jobconfigs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
