jiajunwang commented on pull request #1035: URL: https://github.com/apache/helix/pull/1035#issuecomment-639821889
Sorry, but I don't agree with merging in the current state. 1. Test issues are not my major concern. @pkuwm can say something if he is still concerned. 2. The other remaining comments are easy to fix. Why adding TODO instead of just making the change? At most 10 more minutes work. That will make this PR clean and avoid back-and-forth change later. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
