narendly commented on a change in pull request #1070:
URL: https://github.com/apache/helix/pull/1070#discussion_r436325995
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java
##########
@@ -2223,7 +2223,7 @@ private void validateCurrentThread() {
*
* @return String representation of session id in hexadecimal notation.
*/
- private static String toHexSessionId(long sessionId) {
+ public static String toHexSessionId(long sessionId) {
Review comment:
I agree with this idea. I think it's a valid point to avoid introducing
another public method for ZkClient.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
