zhangmeng916 commented on a change in pull request #1077:
URL: https://github.com/apache/helix/pull/1077#discussion_r437649851
##########
File path: helix-lock/src/main/java/org/apache/helix/lock/DistributedLock.java
##########
@@ -49,4 +49,9 @@
* false if the user is not the lock owner or the lock doesn't have a owner
*/
boolean isCurrentOwner();
+
+ /**
+ * Close the lock and release resources
+ */
+ void close();
Review comment:
So we would expect lock users to explicitly call this one? This is a bit
unintuitive, when put together with the other APIs that are intended for lock
purpose only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
