alirezazamani commented on a change in pull request #1061:
URL: https://github.com/apache/helix/pull/1061#discussion_r437695362
##########
File path: helix-core/src/main/java/org/apache/helix/model/IdealState.java
##########
@@ -721,9 +719,7 @@ private RebalanceMode
normalizeRebalanceMode(IdealStateModeProperty mode) {
String rebalancerName = getRebalancerClassName();
if (rebalancerName != null) {
if (rebalancerName.equals(JobRebalancer.class.getName())
- || rebalancerName.equals(WorkflowRebalancer.class.getName())
- || rebalancerName.equals(GenericTaskRebalancer.class.getName())
- ||
rebalancerName.equals(FixedTargetTaskRebalancer.class.getName())) {
+ || rebalancerName.equals(WorkflowRebalancer.class.getName())) {
Review comment:
I think we are safe because the remove ones have been deprecated around
4 years ago. Perhaps it is time to do some cleaning for TF code base.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
