NealSun96 commented on a change in pull request #1076:
URL: https://github.com/apache/helix/pull/1076#discussion_r437749274



##########
File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java
##########
@@ -1037,6 +1037,53 @@ public static void purgeExpiredJobs(String workflow, 
WorkflowConfig workflowConf
     setNextJobPurgeTime(workflow, currentTime, purgeInterval, 
rebalanceScheduler, manager);
   }
 
+  /**
+   * The function that loops through the all existing workflow contexts and 
removes IdealState and
+   * workflow context of the workflow whose workflow config does not exist.
+   * @param workflowConfigMap
+   * @param resourceContextMap
+   * @param manager
+   */
+  public static void workflowGarbageCollection(final Map<String, 
WorkflowConfig> workflowConfigMap,

Review comment:
       I see the confusion: this function is called on line 75 in the stage, 
please see above. 
   
   I was trying to give you the context: this function was deleted in 
https://github.com/apache/helix/pull/803, and recovering it is the sole purpose 
of this PR. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to