pkuwm commented on pull request #1072: URL: https://github.com/apache/helix/pull/1072#issuecomment-641811251
> * jute.maxbuffer is a Zookeeper lib configuration, I don't think we need to add additional doc about it. > * Regarding how to determine the buffer, I think we can just do what we are doing now. Keeping the behavior the same. > * To avoid confusion, we can do the configuration check when the ZkClient is constructed. Just fail the constructing if the ZK_SERIALIZER_ZNRECORD_WRITE_SIZE_LIMIT_BYTES is configured larger than the ZkClient write limitation. With a clear Exception, users will understand what to do. @jiajunwang Thanks for the input. Size margin would be using the current margin: default 1 MB - ZNRecord size limit (1000 KB) = 24 KB. I've updated the PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
