jiajunwang commented on a change in pull request #1058:
URL: https://github.com/apache/helix/pull/1058#discussion_r438325286
##########
File path:
helix-core/src/main/java/org/apache/helix/tools/ClusterVerifiers/BestPossibleExternalViewVerifier.java
##########
@@ -428,4 +432,20 @@ public String toString() {
return verifierName + "(" + _clusterName + "@" + _zkClient + "@resources["
+ (_resources != null ? Arrays.toString(_resources.toArray()) : "") +
"])";
}
+
+ private class DryrunWagedRebalancer extends
org.apache.helix.controller.rebalancer.waged.DryrunWagedRebalancer {
Review comment:
I should have made myself clearer. What I meant to say is that you can
name the newly defined private class DryrunWagedRebalancer here. But the one in
the package org.apache.helix.controller.rebalancer.waged can still be named
ReadOnlyWagedRebalancer.
The purpose is to differentiate the names so as to avoid confusion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
