xyuanlu edited a comment on pull request #1043:
URL: https://github.com/apache/helix/pull/1043#issuecomment-643568995


   I ran a CPU profiler for my previous version (34bf638). It shows the lamda 
function 
   `defaultDomainPathValuesCache.computeIfAbsent(key, k -> 
(DEFAULT_DOMAIN_PREFIX + key));  `
   and InstanceConfig.getDomaiAsMap are two hotspots for CPU consumption. I 
changed them back to the original implementation. 
   After these changes, the new result of running testCreateClusterTopology is 
~2%, comparing to 
    2~3% for the original code and 6% with previous version. 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to