alirezazamani opened a new pull request #1096: URL: https://github.com/apache/helix/pull/1096
### Issues - [x] My PR addresses the following Helix issues and references them in the PR title: Fixes #1095 ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: In this PR, the Thread sleeps have been removed from TestWorkflowTermination and replaced with TestHelper verify method. Also, testWorkflowJobFail is polling for the Failed state for 10 seconds. However, the tasks in job3 of this workflow need to be retried for 10 times and then this job will go to Failed state. However, 10 seconds might be too short for this case. Hence, in this PR the maxNumberOfAttempts has been set to 5 for the tasks. ### Tests - [x] The following is the result of the "mvn test" command on the appropriate module: helix-core: ``` [ERROR] Failures: [ERROR] TestJobQueueCleanUp.testJobQueueAutoCleanUp ยป ThreadTimeout Method org.testng.... [INFO] [ERROR] Tests run: 1139, Failures: 1, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:26 h [INFO] Finished at: 2020-06-15T16:12:13-07:00 [INFO] ------------------------------------------------------------------------ ``` The failed test succeeded when run individually. mvn test -Dtest="TestJobQueueCleanUp" ``` [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.574 s - in org.apache.helix.integration.task.TestJobQueueCleanUp [INFO] [INFO] Results: [INFO] [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 20.532 s [INFO] Finished at: 2020-06-15T16:43:01-07:00 [INFO] ------------------------------------------------------------------------ ``` helix-rest: ``` [INFO] Tests run: 163, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 47.106 s - in TestSuite [INFO] [INFO] Results: [INFO] [INFO] Tests run: 163, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 52.804 s [INFO] Finished at: 2020-06-15T16:44:19-07:00 [INFO] ------------------------------------------------------------------------ ``` ### Commits - [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - [x] My diff has been formatted using helix-style.xml ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
