kaisun2000 commented on a change in pull request #1104:
URL: https://github.com/apache/helix/pull/1104#discussion_r443065588
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/TestZkCallbackHandlerLeak.java
##########
@@ -605,9 +605,12 @@ public void onStateChange(String instanceName,
List<CurrentState> statesInfo,
"Should have 1 data-watches: MESSAGES");
Assert.assertEquals(watchPaths.get("childWatches").size(), 1,
"Should have 1 child-watches: MESSAGES");
- Assert
- .assertEquals(watchPaths.get("existWatches").size(), 2,
- "Should have 2 exist-watches: CURRENTSTATE/{oldSessionId} and
CURRENTSTATE/{oldSessionId}/TestDB0");
+ result = TestHelper.verify(()-> {
+ Map<String, List<String>> wPaths =
ZkTestHelper.getZkWatch(participantToExpire.getZkClient());
+ return wPaths.get("existWatches").size() == 1;
+ }, 10000);
+ Assert.assertTrue(result,
+ "Should have 1 exist-watches: CURRENTSTATE/{oldSessionId}");
Review comment:
Good point, added the comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
